cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4679) Fix binary protocol NEW_NODE event
Date Mon, 29 Oct 2012 21:06:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486354#comment-13486354
] 

Yuki Morishita commented on CASSANDRA-4679:
-------------------------------------------

I found the difference between patched and trunk.
Your initServer tries to "join ring" even after server is initialized, whilst in trunk it
is guarded by "initialized" check.
I think it is better to check if initialized before calling matbeJoinRing in your patch.
                
> Fix binary protocol NEW_NODE event
> ----------------------------------
>
>                 Key: CASSANDRA-4679
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4679
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 1.2.0 beta 2
>
>         Attachments: 0001-4679.txt, 0002-Start-RPC-binary-protocol-before-gossip.txt,
0003-Remove-hardcoded-initServer-from-AntiEntropyServiceTes.txt
>
>
> As discussed on CASSANDRA-4480, the NEW_NODE/REMOVED_NODE of the binary protocol are
not correctly fired (NEW_NODE is fired on node UP basically). This ticket is to fix that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message