cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4820) Add a close() method to CRAR to prevent leaking file descriptors.
Date Wed, 17 Oct 2012 03:12:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477561#comment-13477561
] 

Jonathan Ellis commented on CASSANDRA-4820:
-------------------------------------------

FIS.close says "If this stream has an associated channel then the channel is closed as well."
 So closing both source and channel is unnecessary.
                
> Add a close() method to CRAR to prevent leaking file descriptors.
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-4820
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4820
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.6
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>             Fix For: 1.1.7
>
>         Attachments: CASSANDRA-4820.patch
>
>
> The problem is that under heavy load Finalizer daemon is unable to keep up with number
of "source" and "channel" fields from CRAR to finalize (as FileInputStream has custom finalize()
which calls close inside) which creates memory/cpu pressure on the machine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message