cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Bailey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4763) SSTableLoader shouldn't get keyspace from path
Date Thu, 04 Oct 2012 18:15:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469571#comment-13469571
] 

Nick Bailey commented on CASSANDRA-4763:
----------------------------------------

I didn't notice before but it looks like we require sstable files to be named according to
the convention cassandra is using? If that is true, then yeah getting the keyspace name from
the actual sstable file name is probably the right approach here.
                
> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
>                 Key: CASSANDRA-4763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Priority: Minor
>
> SSTableLoader currently gets the keyspace it is going to load to from the path of the
directoy of sstables it is loading. This isn't really documented (or I didn't see it), but
also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a snapshot the
file names will have the keyspace which is slightly better but people manually creating their
own sstables might not format them the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message