cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4763) SSTableLoader shouldn't get keyspace from path
Date Fri, 05 Oct 2012 07:58:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470088#comment-13470088
] 

Sylvain Lebresne commented on CASSANDRA-4763:
---------------------------------------------

bq. we require sstable files to be named according to the convention cassandra is using?

We do, and so there is no need for the user to provide the keyspace name as argument to the
loader. That being said, we can lift the limitation that sstables currently must be in a directory
named after the keyspace (I think we all agree here, just wanted to clarify).
                
> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
>                 Key: CASSANDRA-4763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Priority: Minor
>
> SSTableLoader currently gets the keyspace it is going to load to from the path of the
directoy of sstables it is loading. This isn't really documented (or I didn't see it), but
also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a snapshot the
file names will have the keyspace which is slightly better but people manually creating their
own sstables might not format them the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message