Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6356DBFF for ; Wed, 12 Sep 2012 14:15:07 +0000 (UTC) Received: (qmail 48110 invoked by uid 500); 12 Sep 2012 14:15:07 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 48083 invoked by uid 500); 12 Sep 2012 14:15:07 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 48074 invoked by uid 99); 12 Sep 2012 14:15:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2012 14:15:07 +0000 Date: Thu, 13 Sep 2012 01:15:07 +1100 (NCT) From: "Alexey Zotov (JIRA)" To: commits@cassandra.apache.org Message-ID: <2145795315.69499.1347459307633.JavaMail.jiratomcat@arcas> In-Reply-To: <17655693.69494.1347459188110.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (CASSANDRA-4656) StorageProxy histograms MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-4656: ------------------------------------ Description: I suggest to do two improvements: 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules). 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values. Old output: {code} Offset SSTables Write Latency Read Latency Row Size Column Count 1 109298 0 0 0 128700943 2 778 0 0 0 0 .... 1597 0 505 0 0 1916 0 566 0 0 {code} New output: {code} Offset SSTables Write Latency Read Latency Row Size Column Count 1 109298 0 0 0 128700943 2 778 0 0 0 0 .... 1597 0 0 505 0 0 1916 0 0 566 0 0 {code} PS: I've attached a patch that fixes all described problems. was: I suggest to do two improvements: 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules). 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values. Old output: {code} Offset SSTables Write Latency Read Latency Row Size Column Count 1 109298 0 0 0 128700943 2 778 0 0 0 0 .... 1597 0 505 0 0 1916 0 566 0 0 {code} New output: {code} Offset SSTables Write Latency Read Latency Row Size Column Count 1 109298 0 0 0 128700943 2 778 0 0 0 0 .... 1597 0 0 505 0 0 1916 0 0 566 0 0 {code} PS: I've attached a patch that fixes all described problems. > StorageProxy histograms > ----------------------- > > Key: CASSANDRA-4656 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4656 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 1.1.4 > Reporter: Alexey Zotov > Priority: Minor > Attachments: StorageProxy_histograms.patch > > > I suggest to do two improvements: > 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules). > 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values. > Old output: > {code} > Offset SSTables Write Latency Read Latency Row Size Column Count > 1 109298 0 0 0 128700943 > 2 778 0 0 0 0 > .... > 1597 0 505 0 0 > 1916 0 566 0 0 > {code} > New output: > {code} > Offset SSTables Write Latency Read Latency Row Size Column Count > 1 109298 0 0 0 128700943 > 2 778 0 0 0 0 > .... > 1597 0 0 505 0 0 > 1916 0 0 566 0 0 > {code} > PS: I've attached a patch that fixes all described problems. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira