Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34587DF17 for ; Wed, 5 Sep 2012 15:56:08 +0000 (UTC) Received: (qmail 57126 invoked by uid 500); 5 Sep 2012 15:56:08 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 57106 invoked by uid 500); 5 Sep 2012 15:56:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 57095 invoked by uid 99); 5 Sep 2012 15:56:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2012 15:56:08 +0000 Date: Thu, 6 Sep 2012 02:56:07 +1100 (NCT) From: "Sylvain Lebresne (JIRA)" To: commits@cassandra.apache.org Message-ID: <1993679851.39344.1346860568025.JavaMail.jiratomcat@arcas> In-Reply-To: <783781658.3072.1330524958633.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-3979) Consider providing error code with exceptions (and documenting them) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448835#comment-13448835 ] Sylvain Lebresne commented on CASSANDRA-3979: --------------------------------------------- Ok, I've committed the patch with Paul small fix (and the required update to the binary protocol spec). I haven't yet make the change to expose the extra information to thrift but I'll attach the patch for that soonish (I wanted to commit the rest in the meantime because it's a bitch to rebase). > Consider providing error code with exceptions (and documenting them) > -------------------------------------------------------------------- > > Key: CASSANDRA-3979 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3979 > Project: Cassandra > Issue Type: Sub-task > Components: API > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Labels: cql3 > Fix For: 1.2.0 beta 1 > > > It could be a good idea to assign documented error code for the different exception raised. Currently, one may have to parse the exception string (say if one wants to know if its 'create keyspace' failed because the keyspace already exists versus other kind of exception), but it means we cannot improve the error message at the risk of breaking client code. Adding documented error codes with the message would avoid this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira