Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07926D2E0 for ; Wed, 26 Sep 2012 20:37:09 +0000 (UTC) Received: (qmail 60150 invoked by uid 500); 26 Sep 2012 20:37:08 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 60124 invoked by uid 500); 26 Sep 2012 20:37:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 60115 invoked by uid 99); 26 Sep 2012 20:37:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 20:37:08 +0000 Date: Thu, 27 Sep 2012 07:37:08 +1100 (NCT) From: "Yuki Morishita (JIRA)" To: commits@cassandra.apache.org Message-ID: <1424943889.130463.1348691828769.JavaMail.jiratomcat@arcas> In-Reply-To: <1083157387.1785.1309898657293.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Reopened] (CASSANDRA-2858) make request dropping more accurate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuki Morishita reopened CASSANDRA-2858: --------------------------------------- I think this is not working as expected. Truncate hangs on two node cluster using 1.2.0-beta1 binary because truncate response gets dropped every time(and this is why CliTest on trunk is failing today). I think casting long System.currentTimeMillis to int is fragile, and that's causing this line https://github.com/apache/cassandra/blob/cassandra-1.2.0-beta1/src/java/org/apache/cassandra/net/MessageDeliveryTask.java#L43 always evaluates to true. When I tried, System.currentTimeMillis was like 1348691631776, but currentTime there was like 71900832. > make request dropping more accurate > ----------------------------------- > > Key: CASSANDRA-2858 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2858 > Project: Cassandra > Issue Type: Improvement > Reporter: Ryan King > Assignee: Jonathan Ellis > Priority: Minor > Fix For: 1.2.0 beta 1 > > Attachments: 2858.txt, 2858-v2.txt, 2858-v3.txt > > > Based on the discussion in CASSANDRA-2819, we can make the bookkeeping for request times more accurate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira