cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-4608) Add thrift server factory to CassandraDaemon
Date Thu, 27 Sep 2012 13:32:08 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464719#comment-13464719
] 

Jason Brown edited comment on CASSANDRA-4608 at 9/28/12 12:31 AM:
------------------------------------------------------------------

Reworked this patch by removing the dependency of thrift SSL (as per previous comment), so
the thrift server factory aspect can go into c* 1.1. 

Created a TServerFactory interface, and it is implemented by the o.a.c.t.CustomT* classes
(with a nested Factory class). Removed the logic of building the TServer from CassandraDaemon
to those Factory implementions.
TServerCustomFactory chooses the correct TServerFactory to use: it supports the rpc_server_type
sync/async/hsha from the yaml, as well as allowing a custom implementation to be passed in.
Added notes in the yaml for rpc_server_type that you can pass in a custom TServerFactory class
name.
                
      was (Author: jasobrown):
    Reworked this patch by removed the dependency of thrift SSL (as per previous comment),
so the thrift server factory aspect can go into c* 1.1. 

Created a TServerFactory interface, and it is implemented by the o.a.c.t.CustomT* classes
(with a nested Factory class). Removed the logic of building the TServer from CassandraDaemon
to those Factory implementions.
TServerCustomFactory chooses the correct TServerFactory to use: it supports the rpc_server_type
sync/async/hsha from the yaml, as well as allowing a custom implementation to be passed in.
Added notes in the yaml for rpc_server_type that you can pass in a custom TServerFactory class
name.
                  
> Add thrift server factory to CassandraDaemon
> --------------------------------------------
>
>                 Key: CASSANDRA-4608
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4608
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: T Jake Luciani
>            Assignee: Jason Brown
>             Fix For: 1.1.6
>
>         Attachments: 0002-CASSANDRA-4608-Add-thrift-server-factory-to-Cassandr.patch,
4608_cassandra-1.1.patch
>
>
> Add factory class for CassandraServer
> Default impl will be the current thrift server types.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message