Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 29 Aug 2012 06:51:08 +1100 (NCT)
From: "Brandon Williams (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <2070202509.8232.1346183468422.JavaMail.jiratomcat@arcas>
In-Reply-To: <1407734823.63052.1340821124547.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (CASSANDRA-4383) Binary encoding of vnode tokens
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443456#comment-13443456 ] 

Brandon Williams commented on CASSANDRA-4383:
---------------------------------------------

bq. You're using the presence of a hostID as an implicit indication of the version, and a determination of whether or not to try decoding more than just the legacy token. Going back to a test of the MS version might read better, and wouldn't mask a bug where MS >= 1.2 but a host ID wasn't set.

Well, it's six one way and a half dozen the other.  We can look at NET_VERSION instead, but it was also introduced in 1.2, so it's effectively the same thing... and you could have the bug in the opposite direction :(
                
> Binary encoding of vnode tokens
> -------------------------------
>
>                 Key: CASSANDRA-4383
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4383
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.2.0 beta 1
>
>         Attachments: 0001-Add-HOST_ID-and-TOKENS-app-states-binary-serialization.txt, 0002-Fix-tests.txt, 0003-Add-tokens-and-status-atomically.txt
>
>
> Since after CASSANDRA-4317 we can know which version a remote node is using (that is, whether it is vnode-aware or not) this a good opportunity to change the token encoding to binary, since with a default of 256 tokens per node even a fixed-length 16 byte encoding per token provides a great deal of savings in gossip traffic over a text representation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira