Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7432D2DC for ; Fri, 17 Aug 2012 01:17:38 +0000 (UTC) Received: (qmail 27520 invoked by uid 500); 17 Aug 2012 01:17:38 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 27493 invoked by uid 500); 17 Aug 2012 01:17:38 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 27480 invoked by uid 99); 17 Aug 2012 01:17:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2012 01:17:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2D3AE2C5BED for ; Fri, 17 Aug 2012 01:17:38 +0000 (UTC) Date: Fri, 17 Aug 2012 12:17:38 +1100 (NCT) From: "Philip Jenvey (JIRA)" To: commits@cassandra.apache.org Message-ID: <1385008835.22182.1345166258185.JavaMail.jiratomcat@arcas> In-Reply-To: <1268533255.10562.1310579221440.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (CASSANDRA-2897) Secondary indexes without read-before-write MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Jenvey updated CASSANDRA-2897: ------------------------------------- Attachment: 41ec9fc-2897.txt Here's an alternative patch that also tackles just the non-compaction changes (it's a little stale, against 41ec9fc) Briefly looking at Sam's version, I'll note that: o Mine handles entire row deletions in Memtable o but it lacks changes to CompositesSearcher/SchemaLoader/CFMetaDataTest (though I'm not familiar with these code paths, either) o in KeysSearcher, I very likely should be using the compare method from getValueValidator to check for staleness (instead of naively just calling equals) > Secondary indexes without read-before-write > ------------------------------------------- > > Key: CASSANDRA-2897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2897 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 0.7.0 > Reporter: Sylvain Lebresne > Priority: Minor > Labels: secondary_index > Fix For: 1.2.0 > > Attachments: 0001-CASSANDRA-2897-Secondary-indexes-without-read-before-w.txt, 41ec9fc-2897.txt > > > Currently, secondary index updates require a read-before-write to maintain the index consistency. Keeping the index consistent at all time is not necessary however. We could let the (secondary) index get inconsistent on writes and repair those on reads. This would be easy because on reads, we make sure to request the indexed columns anyway, so we can just skip the row that are not needed and repair the index at the same time. > This does trade work on writes for work on reads. However, read-before-write is sufficiently costly that it will likely be a win overall. > There is (at least) two small technical difficulties here though: > # If we repair on read, this will be racy with writes, so we'll probably have to synchronize there. > # We probably shouldn't only rely on read to repair and we should also have a task to repair the index for things that are rarely read. It's unclear how to make that low impact though. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira