cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "paul cannon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4453) Better support of collections in the binary protocol
Date Tue, 14 Aug 2012 21:27:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434538#comment-13434538
] 

paul cannon commented on CASSANDRA-4453:
----------------------------------------

Only a tiny nit here: might be worth removing the `o.a.c.cql3.ResultSet.Metadata.dataTypeCodec`
static instance declaration, since it's unused now and could be a little confusing with `DataType.codec`
serving the same purpose.

Also- this is only somewhat related, but I came across it while testing and reviewing, and
it might be a good place to shoehorn in an extra tweaks: The native_protocol.spec doc doesn't
ever explicitly mention endianness. It's big-endian, network byte order, as probably everyone
would expect, but it's still nice to make that clear.

But yeah, +1.
                
> Better support of collections in the binary protocol
> ----------------------------------------------------
>
>                 Key: CASSANDRA-4453
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4453
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 0001-Adds-generics-to-collection-types.txt, 0002-Support-collections-natively-in-the-binary-protocol.txt,
0003-Use-binary-format-for-thrift.txt
>
>
> Currently, collections results are serialized to json string and send that way. This
doesn't feel right at all for the binary protocol and we should use a simple binary serialization
of the collection instead.
> For the thrift protocol, we might want to keep the json serialization or use the same
binary serialization. I don't really have much opinion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message