Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36A5D9F7A for ; Thu, 19 Jul 2012 23:13:35 +0000 (UTC) Received: (qmail 57630 invoked by uid 500); 19 Jul 2012 23:13:35 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 57602 invoked by uid 500); 19 Jul 2012 23:13:35 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 57591 invoked by uid 99); 19 Jul 2012 23:13:35 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jul 2012 23:13:35 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id E2229141BF8 for ; Thu, 19 Jul 2012 23:13:34 +0000 (UTC) Date: Thu, 19 Jul 2012 23:13:34 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <467907681.79209.1342739614927.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1980875938.245.1328478839174.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-3855) RemoveDeleted dominates compaction time for large sstable counts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418775#comment-13418775 ] Jonathan Ellis commented on CASSANDRA-3855: ------------------------------------------- That's definitely wrong... I think it should be {{if (info != LIVE) return false}} > RemoveDeleted dominates compaction time for large sstable counts > ---------------------------------------------------------------- > > Key: CASSANDRA-3855 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3855 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.1.0 > Reporter: Stu Hood > Assignee: Yuki Morishita > Labels: compaction, deletes, leveled > Attachments: with-cleaning-java.hprof.txt > > > With very large numbers of sstables (2000+ generated by a `bin/stress -n 100,000,000` run with LeveledCompactionStrategy), PrecompactedRow.removeDeletedAndOldShards dominates compaction runtime, such that commenting it out takes compaction throughput from 200KB/s to 12MB/s. > Stack attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira