Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E5F49254 for ; Mon, 16 Jul 2012 17:15:36 +0000 (UTC) Received: (qmail 65189 invoked by uid 500); 16 Jul 2012 17:15:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 65140 invoked by uid 500); 16 Jul 2012 17:15:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 64997 invoked by uid 99); 16 Jul 2012 17:15:36 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2012 17:15:36 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 2A1E8140B94 for ; Mon, 16 Jul 2012 17:15:36 +0000 (UTC) Date: Mon, 16 Jul 2012 17:15:36 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <2080882333.58811.1342458936175.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1490482758.58761.1342458336326.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (CASSANDRA-4441) Fix validation of dates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415404#comment-13415404 ] Jonathan Ellis commented on CASSANDRA-4441: ------------------------------------------- +1, but I'd rather push this to 1.2 only, since DateType has behaved this way since 0.8. > Fix validation of dates > ----------------------- > > Key: CASSANDRA-4441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4441 > Project: Cassandra > Issue Type: Bug > Affects Versions: 1.1.2 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Priority: Minor > Fix For: 1.1.3 > > Attachments: 4441.txt > > > Our date validation (timestamp type) doesn't validate that the date is correct, i.e. it allows dates like 2011-42-42, because DateUtils.parseDate() doesn't do the validation (don't ask me how it can generate a timestamp from bogus date, apparently it can). > The easy fix is to use DateUtils.parseDateStrictly(), which does the validation. This does require to update commons-lang to >= 2.5 (we have 2.4). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira