Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 23 Jul 2012 16:45:35 +0000 (UTC)
From: "Brandon Williams (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <2018845780.91648.1343061935047.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <780012349.74630.1342679854342.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (CASSANDRA-4447) enable jamm for OpenJDK >=
 1.6.0.23
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420771#comment-13420771 ] 

Brandon Williams commented on CASSANDRA-4447:
---------------------------------------------

Can you attach this diff to the ticket?
                
> enable jamm for OpenJDK >= 1.6.0.23
> -----------------------------------
>
>                 Key: CASSANDRA-4447
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4447
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>         Environment: openjdk
>            Reporter: Ilya Shipitsin
>            Priority: Trivial
>             Fix For: 1.1.3
>
>
> we tested jamm with OpenJDK, it works well starting at 1.6.0.23, so I suggest
> --- cassandra-env.sh.dist       2012-07-19 12:24:44.938886154 +0600
> +++ cassandra-env.sh    2012-07-19 12:28:34.913886847 +0600
> @@ -119,8 +119,10 @@
>  
>  # add the jamm javaagent
>  check_openjdk=`"${JAVA:-java}" -version 2>&1 | awk '{if (NR == 2) {print $1}}'`
> -if [ "$check_openjdk" != "OpenJDK" ]
> +check_openjdk_is_good_for_jamm=`"${JAVA:-java}" -version 2>&1 | awk -F "_|\"" '/1\.6\.0/ && $3 < 23 {print "bad" }'`
> +if [ "$check_openjdk" = "OpenJDK" ] && [ "$check_openjdk_is_good_for_jamm" = "bad" ]
>  then
> +else 
>      JVM_OPTS="$JVM_OPTS -javaagent:$CASSANDRA_HOME/lib/jamm-0.2.5.jar"
>  fi

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira