Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 6 Jul 2012 23:04:34 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <1659147624.16911.1341615874947.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <200810271.72397.1340991404141.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (CASSANDRA-4396) Subcolumns not removed when
 compacting tombstoned super column
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4396:
--------------------------------------

    Attachment: 4396-2.txt

patch to fix mixing user-provided timestamps and local deletion time.  includes unit test.
                
> Subcolumns not removed when compacting tombstoned super column
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-4396
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4396
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Nick Bailey
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.0.11, 1.1.3
>
>         Attachments: 4396-2.txt, 4396.txt
>
>
> When we compact a tombstone for a super column with the old data for that super column, we end up writing the deleted super column and all the subcolumn data that is now worthless to the new sstable. This is especially inefficient when reads need to scan tombstones during a slice.
> Here is the output of a simple test I ran to confirm:
> insert supercolumn, then flush
> {noformat}
> Nicks-MacBook-Pro:12:20:52 cassandra-1.0] cassandra$ bin/sstable2json ~/.ccm/1node/node1/data/Keyspace2/Super4-hd-1-Data.db 
> {
> "6b657931": {"supercol1": {"deletedAt": -9223372036854775808, "subColumns": [["737562636f6c31","7468697320697320612074657374",1340990212532000]]}}
> }
> {noformat}
> delete supercolumn, flush again
> {noformat}
> [Nicks-MacBook-Pro:12:20:59 cassandra-1.0] cassandra$ bin/nodetool -h localhost flush
> [Nicks-MacBook-Pro:12:22:41 cassandra-1.0] cassandra$ bin/sstable2json ~/.ccm/1node/node1/data/Keyspace2/Super4-hd-2-Data.db 
> {
> "6b657931": {"supercol1": {"deletedAt": 1340990544005000, "subColumns": []}}
> }
> {noformat}
> compact and check resulting sstable
> {noformat}
> [Nicks-MacBook-Pro:12:22:55 cassandra-1.0] cassandra$ bin/nodetool -h localhost compact 
> [Nicks-MacBook-Pro:12:23:09 cassandra-1.0] cassandra$ bin/sstable2json ~/.ccm/1node/node1/data/Keyspace2/Super4-hd-3-Data.db 
> {
> "6b657931": {"supercol1": {"deletedAt": 1340990544005000, "subColumns": [["737562636f6c31","7468697320697320612074657374",1340990212532000]]}}
> }
> [Nicks-MacBook-Pro:12:23:20 cassandra-1.0] cassandra$ 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira