Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 27 Jul 2012 14:48:34 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <1397701430.110655.1343400514875.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <2140376899.20919.1341788854998.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (CASSANDRA-4427) Restarting a failed bootstrap
 instajoins the ring
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423909#comment-13423909 ] 

Sylvain Lebresne commented on CASSANDRA-4427:
---------------------------------------------

I suspect the test failures are due to the removal of the seeds special case and because our tests are not fully realistic. Namely, in the tests, while localhost is a seed, it gets a schema loaded before joinTokenRing is called, and so it ends up with schemaPresent = true and tries to bootstrap (even though it's the only node). That shouldn't happen in real life but at least on the short term fixing the tests themselves is more work than is worth it, so maybe we can:
* Either we back the isSeed test
* Or exclude ourselves when we check for schemaPresent

Some Preference?
                
> Restarting a failed bootstrap instajoins the ring
> -------------------------------------------------
>
>                 Key: CASSANDRA-4427
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4427
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Brandon Williams
>            Assignee: Jonathan Ellis
>             Fix For: 1.0.11, 1.1.3
>
>         Attachments: 4427-v2.txt, 4427-v3.txt, 4427.txt
>
>
> I think when we made auto_bootstrap = true the default, we broke the check for the bootstrap flag, creating a dangerous situation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira