cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-2116) Separate out filesystem errors from generic IOErrors
Date Tue, 24 Jul 2012 14:39:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421444#comment-13421444
] 

Aleksey Yeschenko edited comment on CASSANDRA-2116 at 7/24/12 2:38 PM:
-----------------------------------------------------------------------

I reverted changes to the SSTII constuctor. Can't reliably throw any FSE from there, from
the calling code either.

SSTW methods' callers that used to catch IOE and do writer.abort() now catch FSWE and do the
same. Any call that wasn't performing any cleanup was left as it was - without the cleanup.

And most FSRE were converted to RTE since in most cases you can't be sure that FS was indeed
the reason for the IOE.

This has to be all this time.
                
      was (Author: iamaleksey):
    I reverted changes to the SSTII constuctor. Can't reliably throw any FSE from there, from
the calling code either.

SSTW methods' callers that used to catch IOE and do writer.abort() now catch FSWE and do the
same. Any call that wasn't performing any cleanup was left as it was - without the cleanup.

And most FSRE were converted to RTE since in most cases you can't be sure that FS was indeed
the reason for the IOE.

This hast to be all this time.
                  
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2116
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Goffinet
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2
>
>         Attachments: 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch,
0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch, CASSANDRA-2116-v3.patch,
CASSANDRA-2116-v4.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out specific errors
such as (reading, writing) from filesystem into FSReadError and FSWriteError. This makes it
possible in the next ticket to allow certain failure modes (kill the server if reads or writes
fail to disk).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message