cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3647) Support set and map value types in CQL
Date Fri, 13 Jul 2012 18:11:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413922#comment-13413922
] 

Jonathan Ellis commented on CASSANDRA-3647:
-------------------------------------------

Pushed some tweaks to https://github.com/jbellis/cassandra/commits/3647-4.  In particular,
renamed the position compare/validate overloads to be more clear what they are for.  With
that clarified, I think it's worth letting polymorphism do the branch here, so having them
in AbstractType is a good thing.

I agree that superficially isComposite() would be a good addition to AbstractType...  but
the way we use instanceof here, I think DCT would have to return false, which would be pretty
confusing.  So instanceof looks like the lesser evil.

I think the current approach for collection representation at the Antlr level is reasonable.
 It may be that Pavel's idea is better but I don't think we're going to make more progress
on that w/o actually coding it up.  So if you want to give that a try in a separate ticket
Pavel, that's fine, but I don't think we should block this.

Overall +1 from me.
                
> Support set and map value types in CQL
> --------------------------------------
>
>                 Key: CASSANDRA-3647
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3647
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>            Reporter: Jonathan Ellis
>            Assignee: Sylvain Lebresne
>              Labels: cql
>             Fix For: 1.2
>
>
> Composite columns introduce the ability to have arbitrarily nested data in a Cassandra
row.  We should expose this through CQL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message