cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Yaskevich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-2116) Separate out filesystem errors from generic IOErrors
Date Mon, 16 Jul 2012 22:04:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415691#comment-13415691
] 

Pavel Yaskevich edited comment on CASSANDRA-2116 at 7/16/12 10:02 PM:
----------------------------------------------------------------------

+1 with Jonathan, that would also allow as us to throw less RTE exceptions like, for example,
in SystemTable or ReadRepairVerbHandler (associated with RowMutation.apply() calls). I also
think that we should keep length() method from RandomAccessReader throwing IOException, as
RAF does originally, because I don't think we want to keep future extenders from using custom
(potentially I/O based) length tracking. Nit: license header is missing from all of the new
files.

Edit: SerializationError seems to be a good idea for the situations where action is not actually
FS related, SerializingCache for one.
                
      was (Author: xedin):
    +1 with Jonathan, that would also allow as us throw less RTE exceptions like, for example,
in SystemTable or ReadRepairVerbHandler (associated with RowMutation.apply() calls). I also
think that we should keep length() method from RandomAccessReader throwing IOException, as
RAF does originally, because I don't think we want to keep future extenders from using custom
(potentially I/O based) length tracking. Nit: license header is missing from all of the new
files.
                  
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2116
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Goffinet
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2
>
>         Attachments: 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch,
0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out specific errors
such as (reading, writing) from filesystem into FSReadError and FSWriteError. This makes it
possible in the next ticket to allow certain failure modes (kill the server if reads or writes
fail to disk).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message