cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject [10/13] git commit: remove poorly mocked test in favor of new test
Date Thu, 26 Jul 2012 22:17:35 GMT
remove poorly mocked test in favor of new test


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/27cd2bfd
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/27cd2bfd
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/27cd2bfd

Branch: refs/heads/trunk
Commit: 27cd2bfda07ac9dc2b336a45aadfb96a168a2d2b
Parents: bce2d6c
Author: T Jake Luciani <jakers@gmail.com>
Authored: Thu Jul 26 14:35:31 2012 -0400
Committer: T Jake Luciani <jakers@gmail.com>
Committed: Thu Jul 26 14:35:31 2012 -0400

----------------------------------------------------------------------
 .../cassandra/thrift/ThriftValidationTest.java     |   45 +--------------
 1 files changed, 1 insertions(+), 44 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/27cd2bfd/test/unit/org/apache/cassandra/thrift/ThriftValidationTest.java
----------------------------------------------------------------------
diff --git a/test/unit/org/apache/cassandra/thrift/ThriftValidationTest.java b/test/unit/org/apache/cassandra/thrift/ThriftValidationTest.java
index e550144..bcbbbf4 100644
--- a/test/unit/org/apache/cassandra/thrift/ThriftValidationTest.java
+++ b/test/unit/org/apache/cassandra/thrift/ThriftValidationTest.java
@@ -52,50 +52,7 @@ public class ThriftValidationTest extends CleanupHelper
     @Test
     public void testColumnValueSizeForIndexedColumn() throws ConfigurationException, InvalidRequestException
     {
-        CfDef cfDef = Schema.instance.getCFMetaData("Keyspace1", "Standard1").toThrift();
-        ByteBuffer columnName = AsciiType.instance.fromString("indexed");
-
-        // add an indexed column definition
-        cfDef.addToColumn_metadata(new ColumnDef(columnName, UTF8Type.class.getCanonicalName())
-                                                 .setIndex_type(IndexType.KEYS)
-                                                 .setIndex_name("indexed_col"));
-
-        CFMetaData metaData = CFMetaData.fromThrift(cfDef);
-
-        Column column = new Column(columnName)
-                            .setValue(new byte[FBUtilities.MAX_UNSIGNED_SHORT + 1])
-                            .setTimestamp(System.currentTimeMillis());
-
-        boolean gotException = false;
-
-        try
-        {
-            // this run should throw an exception
-            ThriftValidation.validateColumnData(metaData, column, false);
-        }
-        catch (InvalidRequestException e)
-        {
-            gotException = true;
-        }
-
-        assert gotException : "expected InvalidRequestException but not received.";
-
-        // change value to be less than unsigned short size
-        column.setValue(new byte[12]);
-
-        gotException = false; // reset flag
-
-        try
-        {
-            // this run should run clean
-            ThriftValidation.validateColumnData(metaData, column, false);
-        }
-        catch (InvalidRequestException e)
-        {
-            gotException = true;
-        }
-
-        assert !gotException : "got unexpected InvalidRequestException";
+       //Replaced by SecondaryIndexColumnSizeTest
     }
 
     @Test


Mime
View raw message