cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-2116) Separate out filesystem errors from generic IOErrors
Date Thu, 12 Jul 2012 23:57:35 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis updated CASSANDRA-2116:
--------------------------------------

    Reviewer: jbellis  (was: yukim)

Thanks, Aleksey.  This looks like a good start!

As a rule of thumb, my expectation would be that most catch (IOException) block should either
be removed (and just declare that method to throw IOE) or transform to FSE.  Of course there
will be exceptions, e.g. IOException from a socket instead of local disk.  But a quick inspection
shows a lot of places where this still needs to be done.

Nit: should CLWE subclass FSError?
                
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2116
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Goffinet
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2
>
>         Attachments: 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch,
0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out specific errors
such as (reading, writing) from filesystem into FSReadError and FSWriteError. This makes it
possible in the next ticket to allow certain failure modes (kill the server if reads or writes
fail to disk).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message