Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E2BD9B4E for ; Wed, 20 Jun 2012 11:46:45 +0000 (UTC) Received: (qmail 12879 invoked by uid 500); 20 Jun 2012 11:46:45 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 12721 invoked by uid 500); 20 Jun 2012 11:46:45 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 12538 invoked by uid 99); 20 Jun 2012 11:46:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 11:46:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 6B84A14002F for ; Wed, 20 Jun 2012 11:46:43 +0000 (UTC) Date: Wed, 20 Jun 2012 11:46:43 +0000 (UTC) From: =?utf-8?Q?Piotr_Ko=C5=82aczkowski_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: <512820682.33570.1340192803443.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1982010397.14039.1331746360526.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-4049) Add generic way of adding SSTable components required custom compaction strategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4049?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 13397436#comment-13397436 ]=20 Piotr Ko=C5=82aczkowski commented on CASSANDRA-4049: ----------------------------------------------- Hmm, I'm also not sure how to do that, but giving them custom names is impo= rtant. What if we want to provide two compaction strategies using custom co= mponents instead of one? What if user wants to switch from one strategy to = another one? We'd have to be very careful that they don't use the same cust= om component for storing different things. So it would be also quite fragil= e.=20 =20 > Add generic way of adding SSTable components required custom compaction s= trategy > -------------------------------------------------------------------------= ------- > > Key: CASSANDRA-4049 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4049 > Project: Cassandra > Issue Type: New Feature > Components: Core > Reporter: Piotr Ko=C5=82aczkowski > Assignee: Piotr Ko=C5=82aczkowski > Priority: Minor > Labels: compaction > Fix For: 1.1.2 > > Attachments: compaction_strategy_cleanup.patch, component_patch.d= iff > > > CFS compaction strategy coming up in the next DSE release needs to store = some important information in Tombstones.db and RemovedKeys.db files, one p= er sstable. However, currently Cassandra issues warnings when these files a= re found in the data directory. Additionally, when switched to SizeTieredCo= mpactionStrategy, the files are left in the data directory after compaction= . > The attached patch adds new components to the Component class so Cassandr= a knows about those files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira