cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wade Simmons (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-4307) isMarkedForDelete can return false if it is a few seconds in the future
Date Tue, 05 Jun 2012 06:10:23 GMT
Wade Simmons created CASSANDRA-4307:
---------------------------------------

             Summary: isMarkedForDelete can return false if it is a few seconds in the future
                 Key: CASSANDRA-4307
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4307
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.0
            Reporter: Wade Simmons


The patch in CASSANDRA-3716 causes some weird issues to arrise when server times don't exactly
match up (and since the resolution is seconds, it is easy to be off by just enough to see
it).

I am seeing a case where during schema propagation .isMarkedForDelete() is checked, but the
timestamp is a few seconds in the future because the schema was sent from a different node.
The code then happily tries to interpret the value of the column as a String, but it is actually
the Int encoded deletion time.

Here is an example in the code that does this check and will do the wrong thing if the deletion
timestamp is even just a few seconds in the future: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java#L607-609

To prove that this is a problem, here is a stack trace of a machine trying to interpret the
"localDeletionTime" value of a DeletedColumn as UTF-8 because the .isMarkedForDeletion() check
failed:

https://gist.github.com/deb064d4377d206368d3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message