cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Alves (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3564) flush before shutdown so restart is faster
Date Thu, 21 Jun 2012 16:31:43 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398546#comment-13398546
] 

David Alves commented on CASSANDRA-3564:
----------------------------------------

thanks for the review

bq. The catch with flushandexit is, you have no way of knowing if it worked or not (from nodetool's
perspective) since either way, you're going to get an error (EOF because the jvm shutdown,
or EOF because ???)

right, I thought about that (might even deserve some special error handling) but the only
alternative that I could think was to make the call async so the RPC method would return fine.
But even that wouldn't provide any meaningful feedback since the user would still have no
idea whether things flushed ok so I left it as is.

If its alright, I'll finish up by adding the cassandra stop command to the shell script and
handle the broken rpc call.
                
> flush before shutdown so restart is faster
> ------------------------------------------
>
>                 Key: CASSANDRA-3564
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3564
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Packaging
>            Reporter: Jonathan Ellis
>            Assignee: David Alves
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 3564.patch
>
>
> Cassandra handles flush in its shutdown hook for durable_writes=false CFs (otherwise
we're *guaranteed* to lose data) but leaves it up to the operator otherwise.  I'd rather leave
it that way to offer these semantics:
> - cassandra stop = shutdown nicely [explicit flush, then kill -int]
> - kill -INT = shutdown faster but don't lose any updates [current behavior]
> - kill -KILL = lose most recent writes unless durable_writes=true and batch commits are
on [also current behavior]
> But if it's not reasonable to use nodetool from the init script then I guess we can just
make the shutdown hook flush everything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message