cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4315) Use EntryWeigher instead of Weigher to Measuring the cache.
Date Thu, 14 Jun 2012 21:46:42 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295334#comment-13295334
] 

Jonathan Ellis commented on CASSANDRA-4315:
-------------------------------------------

LGTM, +1.

Nit: looks like ConcurrentLinkedHashCache constructor was made public unnecessarily
Nit 2: would like to log a warning if MM is unavailable
                
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-4315
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 1.2
>
>         Attachments: 0001-CASSANDRA-4315.patch
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the 
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing
cache (To avoid OOM's for a long Row Keys).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message