cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Alves (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-3885) Support multiple ranges in SliceQueryFilter
Date Tue, 05 Jun 2012 08:49:23 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289250#comment-13289250
] 

David Alves edited comment on CASSANDRA-3885 at 6/5/12 8:48 AM:
----------------------------------------------------------------

The new version of the code has one differece in regard to the blockColumns queue, that's
that it never adds values to it that aren't going to be necessary (as as done previously)
so the blockColumns queue is not really a cache at all, all values there are returned (if
computNext() is called, of course) that's why the "cache" is needed only for a (partial) index
segment size and only in reverse. In fact I can add couple of bb checks and it is no longer
a cache and simply stuff that hasn't been added to the blockColumns queue yet.

Do you think it's important to change the code to mimic how it behaved before?
                
      was (Author: dr-alves):
    The new version of the code has one different in regard to the blockColumns queue, that's
that it never adds values to it that aren't going to be necessary (as as done previously)
so the blockColumns queue is not really a cache at all, all values there are returned (if
computNext() is called, of course) that's why the "cache" is needed only for a (partial) index
segment size and only in reverse. In fact I can add couple of bb checks and it is no longer
a cache and simply stuff that hasn't been added to the blockColumns queue yet.

Do you think it's important to change the code to mimic how it behaved before?
                  
> Support multiple ranges in SliceQueryFilter
> -------------------------------------------
>
>                 Key: CASSANDRA-3885
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3885
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: David Alves
>             Fix For: 1.2
>
>         Attachments: CASSANDRA-3885.patch, CASSANDRA-3885.patch, CASSANDRA-3885.patch
>
>
> This is logically a subtask of CASSANDRA-2710, but Jira doesn't allow sub-sub-tasks.
> We need to support multiple ranges in a SliceQueryFilter, and we want querying them to
be efficient, i.e., one pass through the row to get all of the ranges, rather than one pass
per range.
> Supercolumns are irrelevant since the goal is to replace them anyway.  Ignore supercolumn-related
code or rip it out, whichever is easier.
> This is ONLY dealing with the storage engine part, not the StorageProxy and Command intra-node
messages or the Thrift or CQL client APIs.  Thus, a unit test should be added to ColumnFamilyStoreTest
to demonstrate that it works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message