cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Williams (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4227) StorageProxy throws NPEs for when there's no hostids for a target
Date Tue, 22 May 2012 15:48:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281049#comment-13281049
] 

Brandon Williams commented on CASSANDRA-4227:
---------------------------------------------

I believe the more common situation is you're in the process of upgrading to 1.2 and have
a mixed cluster, but need to generate a hint for an older version that hasn't generated a
nodeid yet.
                
> StorageProxy throws NPEs for when there's no hostids for a target
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-4227
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4227
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.2
>
>         Attachments: 4227_guard_against_npes_for_old_gossip_versions.diff
>
>
> On trunk...
> if there is no host id due to an old node, an info log is generated, but the code continues
to use the null host id causing NPEs in decompose... Should this bypass this code, or perhaps
can the plain ip address be used in this case? don't know.
> as follows...
>                     UUID hostId = StorageService.instance.getTokenMetadata().getHostId(target);
>                     if ((hostId == null) && (Gossiper.instance.getVersion(target)
< MessagingService.VERSION_12))
>                         logger.info("Unable to store hint for host with missing ID, {}
(old node?)", target.toString());
>                     RowMutation hintedMutation = RowMutation.hintFor(mutation, ByteBuffer.wrap(UUIDGen.decompose(hostId)));
>                     hintedMutation.apply();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message