cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4139) Add varint encoding to Messaging service
Date Mon, 21 May 2012 22:46:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280580#comment-13280580
] 

Vijay commented on CASSANDRA-4139:
----------------------------------

* Tried the implementation, We cannot have it in the socket level because of the backward
compatibility, we should wrap the connection only if the version is > 1.2 (which will change
over the period of a connection).
* One thing which we can do is to cache the object which wrapped around but the wrapper is
light weight so it should'nt be a lot of over head. 
* In addition to this I noticed some wired problem (connection disconnects while reading,
which is not the case when we are not caching) which some how breaks if i cache the objects
and while communicating via SSL (i pushed the code to https://github.com/Vijay2win/cassandra/commit/ebf54b3df0419d6a4305aa4b8813e351d4ba7188#L1R176
to reproduce change FBUtilities.getDataOutput to getCachedDataOut)

                
> Add varint encoding to Messaging service
> ----------------------------------------
>
>                 Key: CASSANDRA-4139
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4139
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 1.2
>
>         Attachments: 0001-CASSANDRA-4139-v1.patch, 0001-CASSANDRA-4139-v2.patch, 0001-CASSANDRA-4139-v3.patch,
0002-add-bytes-written-metric.patch, 4139-Test.rtf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message