cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-4222) Improve serializing off-heap cache by not using finalizers
Date Fri, 04 May 2012 23:11:48 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-4222.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.1
         Reviewer: jbellis
         Assignee: Marcus Eriksson

It would be nice to have some kind of optional leak detection finalizer, but in the meantime
you're right that this is unnecessary and a performance hit.  Committed to 1.1.1 and trunk
                
> Improve serializing off-heap cache by not using finalizers
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-4222
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4222
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 1.1.1
>
>         Attachments: 0001-Remove-finalizers-in-FreeableMemory-and-Memory-to-im.patch
>
>
> We have a cluster that takes alot of reads and we have some issues with the off-heap
caching, seeing several G of Finalizer objects on the heap
> My conclusion is that the finalizer thread is too slow to run the finalize method on
the FreeableMemory (and Memory) objects.
> Simply removing the finalize() methods improves performance _alot_ (using finalizers
is 50% slower in my micro benchmarks) and does not leak memory during "normal" use as far
as i can see
> im not sure about the implications for other use cases though

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message