Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 17 Apr 2012 21:35:13 +0000 (UTC)
From: "Aaron Morton (Issue Comment Edited) (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <2118999665.34876.1334698513455.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <549354773.34559.1334694317496.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CASSANDRA-4162) nodetool
 disablegossip does not prevent gossip delivery of writes via
 already-initiated hinted handoff
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255970#comment-13255970 ] 

Aaron Morton edited comment on CASSANDRA-4162 at 4/17/12 9:34 PM:
------------------------------------------------------------------

Disabling thrift and gossip is seen as a way to isolate a node from clients and the other nodes. If it does not stop an in progress HH is there another approach we can use to effectively remove a running node from the ring?

In this case the reporter assumed that since all the other nodes saw the node as down they would stop talking to it.

Would it be ok to check the node state after each page of HH delivery? 
                
      was (Author: amorton):
    Disabling thrift and gossip is seen as a way to isolate a node from clients and the other nodes. If it does not stop an in progress HH is there another approach we can use to effectively remove a running node from the ring?

In this case the reporter assumed that since all the other nodes saw the node as down they would stop talking to it.
                  
> nodetool disablegossip does not prevent gossip delivery of writes via already-initiated hinted handoff
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4162
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4162
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.9
>         Environment: reported on IRC, believe it was a linux environment, nick "rhone", cassandra 1.0.8
>            Reporter: Robert Coli
>            Priority: Minor
>              Labels: gossip
>
> This ticket derives from #cassandra, aaron_morton and I assisted a user who had run "disablethrift" and "disablegossip" and was confused as to why he was seeing writes to his node.
> Aaron and I went through a series of debugging questions, user verified that there was traffic on the gossip port. His node was showing as down from the perspective of other nodes, and nodetool also showed that gossip was not active.
> Aaron read the code and had the user turn debug logging on. The user saw Hinted Handoff messages being delivered and Aaron confirmed in the code that a hinted handoff delivery session only checks gossip state when it first starts. As a result, it will continue to deliver hints and disregard gossip state on the target node.
> per nodetool docs
> "
> disablegossip          - Disable gossip (effectively marking the node dead)
> "
> I believe most people will be using disablegossip and disablethrift for operational reasons, and propose that they do not expect HH delivery to continue, via gossip, when they have run "disablegossip".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira