Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 001039B31 for ; Tue, 24 Apr 2012 18:11:56 +0000 (UTC) Received: (qmail 79280 invoked by uid 500); 24 Apr 2012 18:11:56 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 79250 invoked by uid 500); 24 Apr 2012 18:11:56 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 79242 invoked by uid 99); 24 Apr 2012 18:11:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 18:11:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 18:11:54 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6AA0740D3B1 for ; Tue, 24 Apr 2012 18:11:33 +0000 (UTC) Date: Tue, 24 Apr 2012 18:11:33 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <1859336922.10672.1335291093438.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1737331740.61119.1323483640037.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (CASSANDRA-3606) Resource Leaks in code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis resolved CASSANDRA-3606. --------------------------------------- Resolution: Not A Problem Did you look at what closeQuietly does? It will catch and log exceptions on close, so you don't need the nested try/catch in the caller. > Resource Leaks in code > ---------------------- > > Key: CASSANDRA-3606 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3606 > Project: Cassandra > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Zoltan Farkas > Original Estimate: 1h > Remaining Estimate: 1h > > at the following locations: > At SSLFactory:[line 87] > At SSTableExportTest:[line 83] > At CommitLogTest:[line 191] > At KeyGenerator:[line 108] > At Ec2Snitch.java:[line 74] > At SSTableExportTest.java:[line 83] > At CassandraServer.java:[line 1164] > At CommitLogTest.java:[line 191] > At ByteBufferUtilTest.java:[line 194] > At LazilyCompactedRowTest.java:[line 108] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira