Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECBC9914D for ; Tue, 17 Apr 2012 16:04:43 +0000 (UTC) Received: (qmail 56361 invoked by uid 500); 17 Apr 2012 16:04:43 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 56307 invoked by uid 500); 17 Apr 2012 16:04:43 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 56146 invoked by uid 99); 17 Apr 2012 16:04:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2012 16:04:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2012 16:04:38 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1C3F839E313 for ; Tue, 17 Apr 2012 16:04:17 +0000 (UTC) Date: Tue, 17 Apr 2012 16:04:17 +0000 (UTC) From: "Brandon Williams (Updated) (JIRA)" To: commits@cassandra.apache.org Message-ID: <1756772754.33404.1334678657117.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1168213245.28782.1334589136624.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (CASSANDRA-4155) Make possible to authenticate user when loading data to Cassandra with BulkRecordWriter. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-4155?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-4155: ---------------------------------------- Fix Version/s: 1.1.1 Thanks for the patch, Michal! I'm fine with the 'nicer' version, since the= only place ExternalClient is instantiated is in BOF and multiple construct= ors with logic around which one to use starts getting messy, but let's go a= head and remove the old constructor (or rather, change the signature of the= existing one depending on how you look at it) since we don't need it anymo= re. =20 > Make possible to authenticate user when loading data to Cassandra with Bu= lkRecordWriter. > -------------------------------------------------------------------------= --------------- > > Key: CASSANDRA-4155 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4155 > Project: Cassandra > Issue Type: Improvement > Reporter: Micha=C5=82 Michalski > Priority: Minor > Fix For: 1.1.1 > > Attachments: trunk-4155-nicer-version.txt, trunk-4155.txt > > > I need to use the authorization feature (i.e. provided by SimpleAuthentic= ator and SimpleAuthority). The problem is that it's impossible now to pass = the credentials (cassandra.output.keyspace.username and cassandra.output.ke= yspace.passwd) to org.apache.cassandra.hadoop.ConfigHelper because of no se= tters for these variables. Moreover, even if they could be passed, nothing = will change because they are unused - ExternalClient class from org.apache.= cassandra.hadoop.BulkRecordWriter is not making use of them; it's not even = receiving them and no authorization is provided. > The proposed improvement is to make it possible to authenticate user when= loading data to Cassandra with BulkRecordWriter by adding appropriate sett= ers to ConfigHelper and then passing credentials to ExternalClient class so= it could use it for authorization request. > I have created a patch for this which I attach.=20 > This improvement was made in the way that does not charm existing Externa= lClient interface usage, but I think that it would be a bit nicer way to ca= ll the new constructor every time (optionally with username and password se= t to null) in this code and keeping the old one, instead of having and usin= g two different constructors in two different cases in one method. However,= it's my first patch for Cassandra, so I submit a less "agressive" one and = I'm waiting for suggestions for to modify it :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira