cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "paul cannon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-4173) cqlsh: in cql3 mode, use cql3 quoting when outputting cql
Date Wed, 25 Apr 2012 20:26:19 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

paul cannon updated CASSANDRA-4173:
-----------------------------------

    Attachment: 4173.patch.txt

break out calls to cql_escape so that they're separated by the sort of thing being quoted
(column/cf/keyspace name vs. value) and go through the Shell object, so it can route to cql3
quoting or cql2 quoting as appropriate.

This should fix all uses of quoting except in tab completion areas.

Fix attached here and in the 4173 branch in my github, tagged here:

https://github.com/thepaul/cassandra/tree/pending/4173

The patch is meant to go on top of 4164.patch.txt from CASSANDRA-4164.
                
> cqlsh: in cql3 mode, use cql3 quoting when outputting cql
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-4173
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4173
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 1.1.0
>            Reporter: paul cannon
>            Assignee: paul cannon
>            Priority: Minor
>              Labels: cql3, cqlsh
>             Fix For: 1.1.1
>
>         Attachments: 4173.patch.txt
>
>
> when cqlsh needs to output a column name or other term which needs quoting (say, if you
run DESCRIBE KEYSPACE and some column name has a space in it), it currently only knows how
to quote in the cql2 way. That is,
> {noformat}
> cqlsh:foo> describe columnfamily bar
> CREATE COLUMNFAMILY bar (
>   a int PRIMARY KEY,
>   'b c' text
> ) WITH
> ...
> {noformat}
> cql3 does not recognize single quotes around column names, or columnfamily or keyspace
names either. cqlsh ought to learn how to use double-quotes instead when in cql3 mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message