cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-4114) Default read_repair_chance value is wrong
Date Wed, 04 Apr 2012 16:19:23 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis updated CASSANDRA-4114:
--------------------------------------

    Attachment: 4114.txt

I think that since the cli has behaved this way since 1.0.0, changing it now might surprise
people who didn't read NEWS (and thus don't know that it was supposed to change to default
of 0.1).  So I propose fixing this in 1.1.0 instead. 

(For completeness, I note that cql {{CREATE COLUMNFAMILY}} does default to 0.1 correctly since
it does not build its CFMetadata objects from Thrift.)

                
> Default read_repair_chance value is wrong
> -----------------------------------------
>
>                 Key: CASSANDRA-4114
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4114
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Manoj Kanta Mainali
>            Assignee: Jonathan Ellis
>            Priority: Trivial
>             Fix For: 1.1.0
>
>         Attachments: 4114.txt
>
>
> The documents says that the default read_repair_chance value is 0.1, and it is also declared
so in CFMetaDeta. However, when creating a column family with "create column family foo" via
cli and checking with "show keyspaces" shows that the read_repair_chance=1.0. This also happens
when creating the column family through Hector.
> Going through the code, I find that in CfDef class, the constructor without any parameters
sets the read_repair_chance to 1. Changing this value to 0.1 seems to create a column family
with the 0.1 read_repair_chance. The best might be to remove it from the CfDef as the read_repair_chance
is set to the default value in CFMetaDeta.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message