cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3617) Clean up and optimize Message
Date Tue, 03 Apr 2012 20:28:24 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245695#comment-13245695
] 

Yuki Morishita commented on CASSANDRA-3617:
-------------------------------------------

Still in progress, but rebased, implemented serializedSize for all IVersionedSerializer and
added unit tests for those. 
Current work is at https://github.com/yukim/cassandra/branches/3617.

CliTest and RemoveTest still fail, but all other unit tests including SerializationsTests
pass.
                
> Clean up and optimize Message
> -----------------------------
>
>                 Key: CASSANDRA-3617
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3617
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Yuki Morishita
>             Fix For: 1.2
>
>
> The Message class has grown largely by accretion and it shows.  There are several problems:
> - Outbound and inbound messages aren't really the same thing and should not be conflated
> - We pre-serialize message bodies to byte[], then copy those bytes onto the Socket buffer,
instead of just keeping a reference to the object being serialized and then writing it out
directly to the socket
> - MessagingService versioning is poorly encapsulating, scattering version variables and
references to things like CachingMessageProducer across the codebase

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message