cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Yaskevich (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-4138) Add varint encoding to Serializing Cache
Date Wed, 18 Apr 2012 14:02:04 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pavel Yaskevich updated CASSANDRA-4138:
---------------------------------------

    Attachment: CASSANDRA-4138-v3.patch

Made some refactoring (added license headers, renamed variables etc.)

I have removed o.a.c.util package that you created and moved Encoded* clases to o.a.c.utils.vint,
done the same for tests.

Renamed DBContants to DBTypeSizes with two statics NATIVE and VINT to be used for sizeof(type)
+ all related code.

Moved class EncodedDBConstant to the DBTypeSized and renamed it to VIntEncodedDBTypeSizes,
the same done for native - it's NativeDBTypeSizes now.

Changed {encode, decode}VInt methods visibility to private and renamed to vint{Encode, Decode}
+ added a comment why we  use single method for all integer types.

One problem remains - CompactionsTest fails after your modifications.

                
> Add varint encoding to Serializing Cache
> ----------------------------------------
>
>                 Key: CASSANDRA-4138
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4138
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 0001-CASSANDRA-4138-Take1.patch, 0001-CASSANDRA-4138-V2.patch, 0002-sizeof-changes-on-rest-of-the-code.patch,
CASSANDRA-4138-v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message