cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Yaskevich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4138) Add varint encoding to Serializing Cache
Date Fri, 27 Apr 2012 23:30:50 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264108#comment-13264108
] 

Pavel Yaskevich commented on CASSANDRA-4138:
--------------------------------------------

bq. It's not immediately clear to me what the changes in ByteBufferUtil are doing – EDOS
doesn't change writeByte so what is breaking? is this backwards compatible?

I can explain ByteBufferUtil changes - instead of doing short write manually (copy code that
does it from DO) it just uses appropriate method from the DataOutput which would handle the
short encode and write. EDOS don't really need to change the way we write bytes, this is only
about encoding integer types compactly. All legacy tests are passing and this doesn't seem
to touch code so dramatically to break it as soon as it's all about SerializingCache...

bq. Have you done any smoke tests to see what kind of savings you get on typical cached data?
In other words: is our intuition correct that this is worth the extra complexity?

This is question to Vijay so I won't interfere, just want to note that he pointed out in the
first comment that this saves ~10% of memory compared to normal DIS.
                
> Add varint encoding to Serializing Cache
> ----------------------------------------
>
>                 Key: CASSANDRA-4138
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4138
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 0001-CASSANDRA-4138-Take1.patch, 0001-CASSANDRA-4138-V2.patch, 0001-CASSANDRA-4138-v4.patch,
0002-sizeof-changes-on-rest-of-the-code.patch, CASSANDRA-4138-v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message