cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4079) Check SSTable range before running cleanup
Date Mon, 16 Apr 2012 14:20:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254714#comment-13254714
] 

Sylvain Lebresne commented on CASSANDRA-4079:
---------------------------------------------

A small nit: I know this is a bit of a mess, but we also have ExcludingBounds and IncludingExcludingBounds
that extends AbstractBounds which Range.intersects() doesn't handle. I don't think we should
bother supporting them here since we don't need it, but I'd prefer protecting against future
misuse of interests. I'd also prefer not having the method static for no good reason. Typically
I would add intersects as a method of Bounds (that would take a list of Range).
                
> Check SSTable range before running cleanup
> ------------------------------------------
>
>                 Key: CASSANDRA-4079
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4079
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benjamin Coverston
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.1.1
>
>         Attachments: 4079.txt
>
>
> Before running a cleanup compaction on an SSTable we should check the range to see if
the SSTable falls into the range we want to remove. If it doesn't we can just mark the SSTable
as compacted and be done with it, if it does, we can no-op.
> Will not help with STCS, but for LCS, and perhaps some others we may see a benefit here
after topology changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message