Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 7 Mar 2012 17:40:57 +0000 (UTC)
From: "Vijay (Issue Comment Edited) (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <280298112.34959.1331142057579.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <689754973.20432.1330899899053.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CASSANDRA-3997) Make
 SerializingCache Memory Pluggable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224533#comment-13224533 ] 

Vijay edited comment on CASSANDRA-3997 at 3/7/12 5:40 PM:
----------------------------------------------------------

Ohhh sorry for the confusion. 
JEMAlloc's case: The Malloc/Free should done by ANY one thread at a time. The test had 100 Threads doing malloc/free but only one will actually malloc/free at a time and the "Time taken" shows the raw speed.
TCMalloc's case: Only one thread should be malloc and doing free. (Even after this it was crashing randomly because of illegal memory access, hence i said JEMalloc hasnt crashed).

The test code does exactly the above.... The implementation should deal with it and avoid contending for malloc and free with multiple threads. Once we deal with it, it works well.
                
      was (Author: vijay2win@yahoo.com):
    Ohhh sorry for the confusion. 
JEMAlloc's case: The Malloc/Free should be one only be done by any one thread at a time. The test had 100 Threads doing malloc/free but only one will actually malloc/free at a time and the "Time taken" shows the raw speed.
TCMalloc's case: One thread should be malloc and doing free. (Even making this single threaded it was crashing randomly because of illegal memory access errors, hence i said JEMalloc hasnt crashed).

The test code does exactly the above.... The implementation should deal with it and avoid contending for malloc and free with multiple threads. Once we deal with it, it works well.
                  
> Make SerializingCache Memory Pluggable
> --------------------------------------
>
>                 Key: CASSANDRA-3997
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3997
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>              Labels: cache
>             Fix For: 1.2
>
>         Attachments: jna.zip
>
>
> Serializing cache uses native malloc and free by making FM pluggable, users will have a choice of gcc malloc, TCMalloc or JEMalloc as needed. 
> Initial tests shows less fragmentation in JEMalloc but the only issue with it is that (both TCMalloc and JEMalloc) are kind of single threaded (at-least they crash in my test otherwise).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira