Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 30 Mar 2012 14:18:26 +0000 (UTC)
From: "Sylvain Lebresne (Updated) (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <202840130.37975.1333117106077.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1842290724.7185.1332491488173.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CASSANDRA-4076) Remove
 get{Indexed,Sliced}ReadBufferSizeInKB methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-4076:
----------------------------------------

    Attachment: 4076.txt

Trivial patch attached. I'd like to get that in 1.1.0 just before this remove a (useless) option from the cassandra.yaml file and I want to avoid doing that on a minor release. Besides, this really just remove dead code.
                
> Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
> ----------------------------------------------------
>
>                 Key: CASSANDRA-4076
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Sylvain Lebresne
>            Priority: Trivial
>             Fix For: 1.1.0
>
>         Attachments: 4076.txt
>
>
> Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira