cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Resolved) (JIRA)" <>
Subject [jira] [Resolved] (CASSANDRA-4070) CFS.setMaxCompactionThreshold doesn't allow 0 unless min is also 0
Date Thu, 22 Mar 2012 12:46:22 GMT


Sylvain Lebresne resolved CASSANDRA-4070.

    Resolution: Fixed
      Reviewer: jbellis

Committed, thanks

I agree that we probably should have a better way to disable compaction. Actually given that
leveled compaction pretty much ignore the max and min threshold, I think we should think about
moving those to the compaction options.
> CFS.setMaxCompactionThreshold doesn't allow 0 unless min is also 0
> ------------------------------------------------------------------
>                 Key: CASSANDRA-4070
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Trivial
>             Fix For: 1.0.9
>         Attachments: 4070.patch
> Thrift allows to set the max compaction threshold to 0 to disable compaction. However,
CFS.setMaxCompactionThreshold throws an exception min > max even if max is 0.
> Note that even if someone sets 0 for both the min and max thresholds, we'll can have
a problem because SizeTieredCompaction calls CFS.setMaxCompactionThreshold before calling
CFS.setMinCompactionThreshold and thus will trigger the RuntimeException when it shouldn't.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message