cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Williams (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-3986) Cli shouldn't call FBU.getBroadcastAddress needlessly
Date Thu, 01 Mar 2012 16:36:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brandon Williams resolved CASSANDRA-3986.
-----------------------------------------

    Resolution: Fixed
      Reviewer: dbrosius@apache.org

Committed.  Probably only causes a problem on windows because the cli doesn't have the yaml
in the classpath from the bat file.
                
> Cli shouldn't call FBU.getBroadcastAddress needlessly
> -----------------------------------------------------
>
>                 Key: CASSANDRA-3986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3986
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.8
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.9, 1.1.0
>
>         Attachments: 3986.txt
>
>
> The cli is calling this, which causes yaml to be loaded, but the broadcast address isn't
needed.
> {code}
>             // adding default data center from SimpleSnitch
>             if (currentStrategyOptions == null || currentStrategyOptions.isEmpty())
>             {
>                 SimpleSnitch snitch = new SimpleSnitch();
>                 Map<String, String> options = new HashMap<String, String>();
>                 options.put(snitch.getDatacenter(FBUtilities.getBroadcastAddress()),
"1");
>                 ksDef.setStrategy_options(options);
>             }
> {code}
> because SimpleSnitch always returns 'datacenter1'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message