cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3792) add type information to new schema_ columnfamilies
Date Mon, 12 Mar 2012 09:03:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227379#comment-13227379
] 

Sylvain Lebresne commented on CASSANDRA-3792:
---------------------------------------------

Follow-up changes are on https://github.com/pcmanus/cassandra/commits/3792.  There is like
9 commits on top of the 3 previous ones but some are rather small. This fixes a number of
bugs and make all unit test pass.

One of the thing it does is adding a gc_grace_seconds > 0 for schema column families. This
is necessary since we now uses normal deletes. I've added a test at https://github.com/riptano/cassandra-dtest/blob/master/schema_test.py
that fails with current 1.1.0 to show that problem. This does lead to the question of what
value to use for that gc_grace. The current patches set this to 3 months, hoping that no one
will keep a node dead that long, but there is some amount of random in that choice.

Note that following those patches, CQL still convert to and from thrift structures to reuse
ThriftValidation methods. I've created CASSANDRA-4037 to fix that. I also think we should
consider using an enumeration (or equivalent) for the CFMetadata properties names, as reusing
strings is a bit fragile, but I'm fine leaving that to a follow up ticket.

                
> add type information to new schema_ columnfamilies
> --------------------------------------------------
>
>                 Key: CASSANDRA-3792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3792
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>            Assignee: Sylvain Lebresne
>             Fix For: 1.1.0
>
>
> Should also fix the quotes that the current Thrift-based serialization embeds in string
schema data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message