cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
Date Wed, 28 Mar 2012 23:29:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240826#comment-13240826
] 

Vijay commented on CASSANDRA-4099:
----------------------------------

I think we can remove

{code}
                if (version <= MessagingService.current_version)
                {
                    int size = input.readInt();
                    byte[] headerBytes = new byte[size];
                    input.readFully(headerBytes);
                    StreamHeader streamHeader = StreamHeader.serializer().deserialize(new
DataInputStream(new FastByteArrayInputStream(headerBytes)), version);
                    // why? see => CASSANDRA-4099
                    from = streamHeader.broadcastAddress;
{code}

Because the version will be already set by the Gossip hopefully :) but I still dont understand
why we streaming needs to be version specific though.
                
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4099
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>         Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the
problem is we dont know until the first packet is received, this ticket is to work around
the problem until it reads the first packet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message