cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
Date Thu, 29 Mar 2012 17:56:23 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241440#comment-13241440
] 

Jonathan Ellis commented on CASSANDRA-4099:
-------------------------------------------

I still don't get it.

{noformat}
+            from = msg.getFrom(); // why? see => CASSANDRA-4099
-                Gossiper.instance.setVersion(msg.getFrom(), version);
+                Gossiper.instance.setVersion(from, version);
{noformat}

How is the first getFrom, not the same as the one we've de-inlined?
                
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4099
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>         Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the
problem is we dont know until the first packet is received, this ticket is to work around
the problem until it reads the first packet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message