cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4099) IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
Date Wed, 28 Mar 2012 23:17:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240819#comment-13240819
] 

Vijay commented on CASSANDRA-4099:
----------------------------------

Nope there is 2 places where we set the from one is during the stream just before we start.
the second place is when it is not a stream and when we recive the first message so we should
be ok and should never be null.

1)

{code}
                    // why? see => CASSANDRA-4099
                    from = streamHeader.broadcastAddress;
                    stream(streamHeader, input);
{code}

2)

{code}

Message msg = receiveMessage(input, version);
            from = msg.getFrom(); // why? see => CASSANDRA-4099
{code}

Hope it makes sense.
                
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4099
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>         Attachments: 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the
problem is we dont know until the first packet is received, this ticket is to work around
the problem until it reads the first packet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message