cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-3869) [patch] don't duplicate ByteBuffers when hashing
Date Thu, 09 Feb 2012 03:48:00 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-3869.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1
         Reviewer: jbellis

committed v2; I think your first intuition was right that this is a hot path worth optimizing.
                
> [patch] don't duplicate ByteBuffers when hashing
> ------------------------------------------------
>
>                 Key: CASSANDRA-3869
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3869
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>             Fix For: 1.1
>
>         Attachments: dont_dup_bb_for_hash.diff, dont_dup_bb_for_hash2.diff
>
>
> given how often hashing of ByteBuffers occurs, don't duplicate the ByteBuffer when hashing.
(trivial - as the byte array was never copied just the BB wrapper -- but still).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message