cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3755) NPE on invalid CQL DELETE command
Date Wed, 08 Feb 2012 17:12:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203752#comment-13203752
] 

Sylvain Lebresne commented on CASSANDRA-3755:
---------------------------------------------

I believe the right fix would be to use ThriftValidation.validateColumnFamily that catches
that kind of problems. Looking at DeleteStatement, it seems that it re-validate the column
family for each key in mutationForKey(), but that's done later and thus the NPE is thrown
first. We should probably move the validateColumnFamily up in prepareRowMutations() and then
pass the resulting metadata as an argument of mutationForKey to avoid the multiple validation.
                
> NPE on invalid CQL DELETE command
> ---------------------------------
>
>                 Key: CASSANDRA-3755
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3755
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.7
>            Reporter: paul cannon
>            Assignee: Dave Brosius
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.8
>
>         Attachments: unknown_cf.diff
>
>
> The CQL command {{delete from k where key='bar';}} causes Cassandra to hit a NullPointerException
when the "k" column family does not exist, and it subsequently closes the Thrift connection
instead of reporting an IRE or whatever. This is probably wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message