cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (Commented) (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-3772) Evaluate Murmur3-based partitioner
Date Mon, 13 Feb 2012 19:48:59 GMT


Yuki Morishita commented on CASSANDRA-3772:


Patch needs rebase, but looking at the patch, I noticed the following:

private static byte[] hashMurmur3(ByteBuffer... data)
    HashFunction hashFunction = murmur3HF.get();
    Hasher hasher = hashFunction.newHasher();
    // snip

Isn't that slow if you instantiate every time? I looked up guava source code but I saw no
way to "reset", so I guess the above is the only thing you could do...

I also note that CASSANDRA-2975 will implement MurmurHash3, so I think it is better not to
introduce external library. What do you think?
> Evaluate Murmur3-based partitioner
> ----------------------------------
>                 Key: CASSANDRA-3772
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Dave Brosius
>             Fix For: 1.2
>         Attachments: try_murmur3.diff
> MD5 is a relatively heavyweight hash to use when we don't need cryptographic qualities,
just a good output distribution.  Let's see how much overhead we can save by using Murmur3

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message