cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-3823) [patch] remove bogus assert - never false
Date Wed, 01 Feb 2012 05:50:59 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dave Brosius updated CASSANDRA-3823:
------------------------------------

    Attachment: remove_bogus_assert.diff
    
> [patch] remove bogus assert - never false
> -----------------------------------------
>
>                 Key: CASSANDRA-3823
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3823
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: remove_bogus_assert.diff
>
>
> code asserts that SSTableScanner is Closeable
>              final SSTableScanner scanner = sstable.getScanner(filter);
>              scanner.seekTo(startWith);
> -            assert scanner instanceof Closeable; // otherwise we leak FDs
> always is, unless null, but of course the line before would throw NPE. 
> Just confusing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message